PM-14458: Update notifications permissions request #4229
Merged
+369
−89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
david-livefront
requested review from
brian-livefront,
dseverns-livefront,
ahaisting-livefront and
a team
as code owners
david-livefront
force-pushed
the
PM-14458-notifications-permission
branch
from
4449834
to
837afbe
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4229 +/- ##
=======================================
Coverage ? 89.05%
=======================================
Files ? 445
Lines ? 38756
Branches ? 5418
=======================================
Hits ? 34515
Misses ? 2362
Partials ? 1879 ☔ View full report in Codecov by Sentry. |
david-livefront
force-pushed
the
PM-14458-notifications-permission
branch
from
837afbe
to
b1bf299
Compare
...ain/java/com/x8bit/bitwarden/ui/platform/components/bottomsheet/BitwardenModalBottomSheet.kt
Show resolved
Hide resolved
david-livefront
force-pushed
the
PM-14458-notifications-permission
branch
from
b1bf299
to
3dde55c
Compare
|
Thanks @dseverns-livefront |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
PM-14458
📔 Objective
This PR updates the way we request the notifications permission. Instead of prompting in the vault screen with no context, we not prompt in the Pending Requests Screen.
📸 Screenshots
Screen_recording_20241104_163444.mp4